Open
Conversation
✅ Deploy Preview for aquamarine-heliotrope-f610d4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
感谢贡献，友情提醒下：需要把i8n.csv的修改提到PR里面。 |
Contributor
Author
改好了，润色也在实机测试过了 |
solosky
requested changes
May 20, 2024
| [_L_APP_CHAMELEON_CARD_SET_NICK_SUCCESS] = "Nickname is Set", | ||
| [_L_APP_CHAMELEON_CARD_SET_NICK_FAILED] = "Set Nickname Failed", | ||
| [_L_APP_CHAMELEON_CARD_INPUT_NICK] = "Enter Nickname:", | ||
| [_L_APP_CHAMELEON_CARD_DATA_LOAD] = "Load Card Data...", |
Owner
There was a problem hiding this comment.
建议保留 Load.. 和 Save.. 后面加card data 感觉有点多余，也不能强调是Load还是Save
| [_L_SHOW_QRCODE] = "Display QR Code", | ||
| [_L_AMIIBO_KEY_UNLOADED] = "Amiibo Key Not Found", | ||
| [_L_UPLOAD_KEY_RETAIL_BIN] = "Upload key_retail.bin file\nto the root directory of\nthe external storage.", | ||
| [_L_KNOW] = "Understood", |
| [_L_APP_AMIIBOLINK] = "AmiiboLink", | ||
| [_L_APP_BLE] = "BLE File Transfer", | ||
| [_L_APP_BLE_TITLE] = "BLE File Transfer", | ||
| [_L_APP_BLE_TITLE] = " File Transfer", |
Contributor
Author
There was a problem hiding this comment.
好的我修改完实机编译一下看看
文件传输那里多个空格是因为简体中文有没有空格都看上去不突兀，但英文版的蓝牙图标连着后面的字串就显得很突兀。把上一版里的BLE去掉也是同样的原因，因为那个界面里这行是居中的，加上BLE的话就太长了。要不你考虑一下这一处源码里图标后面总是跟一个空格？
类似的还有个地方想不起来在哪儿了，一般来讲短省略号都是三个点，但那一处源码里hardcoded有两个点没有用printf，后来也就没改了。
|
加入繁中amiidb_game.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a lot of upstream updates since my previous PR so I thought it's time to update!
Mainly focused on the interpretation quality and use of language. A few cosmetic changes (such as "File Transfer" in BLE screen as there's already a BT icon in front of it), too.
我先放draft PR吧，我得再过一遍UI看看还有没有要改的地方。屏幕太小了很多地方不太能挤得下。而且最近才有的二奶机，终于舍得为了一些字串而重置设置和格式化了😏