Skip to content

fix: restrict creation deposit release to the market creator #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hman38705 merged 1 commit into from
Mar 28, 2026
Merged

fix: restrict creation deposit release to the market creator #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/predict-iq/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,9 @@ impl PredictIQ {
pub fn claim_creation_deposit(
e: Env,
market_id: u64,
caller: Address,
) -> Result<(), ErrorCode> {
crate::modules::markets::claim_creation_deposit(&e, market_id)
crate::modules::markets::claim_creation_deposit(&e, market_id, caller)
}

// Governance and Upgrade Functions
Expand Down
8 changes: 6 additions & 2 deletions contracts/predict-iq/src/modules/markets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,15 @@ pub fn set_creation_deposit(e: &Env, amount: i128) -> Result<(), ErrorCode> {
pub fn claim_creation_deposit(
e: &Env,
market_id: u64,
caller: soroban_sdk::Address,
) -> Result<(), ErrorCode> {
let mut market = get_market(e, market_id).ok_or(ErrorCode::MarketNotFound)?;

// 1. Only the creator can claim their own deposit
market.creator.require_auth();
// Only the creator can claim their own deposit
if caller != market.creator {
return Err(ErrorCode::NotAuthorized);
}
caller.require_auth();

// 2. Market must be fully resolved
if market.status != MarketStatus::Resolved {
Expand Down
Loading