Improved Curse Logic and Added More Config Options#25
Open
ali-afk wants to merge 9 commits intosomeaddons:1.20.1from
Open
Improved Curse Logic and Added More Config Options#25ali-afk wants to merge 9 commits intosomeaddons:1.20.1from
ali-afk wants to merge 9 commits intosomeaddons:1.20.1from
Conversation
Add maxCurseChance int to config, default is 75. Fix some typos in config descriptions. Move entries around for easier reading.
Changed curse logic to reflect curseEveryXLevels override. Make config look neater. Add debug logging to new configs
Fix config typos.
…er now. - Make some one-line if-statements in parts of code easier to read. - Clarify curseEveryXLevels config description.
…se it is flagged incompatible by isCompatibleWithAll() - Fix bug in enchantManually() where curse with previous level was not removed when level was incremented. - Make sure guaranteedCursesToApply are not counted as part of newLevel in rollAndApplyCurseTo() - Better curse scaling logic: faster in the beginning, slower later on. - Clarified config to reflect scaling logic changes.
- Add KintsugiRemixEnchantmentMenuMixin for [Kintsugi](https://github.com/avivbeeri/kintsugi "Go to GitHub") mod compat, [Curseforge](https://www.curseforge.com/minecraft/mc-mods/kintsugi "Go to Curseforge")
- Add KintsugiRemixEnchantmentMenuMixin for Kintsugi mod compat, Curseforge: https://www.curseforge.com/minecraft/mc-mods/kintsugi, Github: https://github.com/avivbeeri/kintsugi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes: