Skip to content
This repository was archived by the owner on Nov 13, 2024. It is now read-only.

add ability for additional service ports to be added as ports on the deployment/statefulset ports.#27

Open
itewk wants to merge 1 commit intosonatype:mainfrom
itewk:feature/dynamic-deployment-stateful-ports
Open

add ability for additional service ports to be added as ports on the deployment/statefulset ports.#27
itewk wants to merge 1 commit intosonatype:mainfrom
itewk:feature/dynamic-deployment-stateful-ports

Conversation

@itewk
Copy link

@itewk itewk commented Jun 16, 2021

Purpose

possible solution for issue #26.

possible issues

  • this defaults to always creating any additional service ports as pod ports
    • could keep this as is, i can't think of why you would add an extra service port and not expose the port on the pod
    • could add a flag to say whether to expose the port in the pod
    • could use a completly different dictionary from the service dictionary to speicy the pod ports
  • there is a 15 character limit on pod port names that can cause issues
    • not sure how to deal with this one

testing

I have tested this in my environment and it works.

@itewk
Copy link
Author

itewk commented Jun 29, 2021

any thoughts on this solution to issue #26 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant