feat: add ORDER BY support and improve unsupported feature errors#12
Merged
feat: add ORDER BY support and improve unsupported feature errors#12
Conversation
- Add ORDER BY clause with ASC/DESC sorting (single and multiple columns) - Extract result processing (DISTINCT, ORDER BY) into result_processor module - Add word boundary checks to keywords to prevent prefix conflicts (e.g. OR vs ORDER) - Add EOI to grammar to ensure full input consumption - Detect unsupported Cypher keywords and return clear error messages - Add 14 new tests (parser, executor, result_processor) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonesuke
force-pushed
the
feat/order-by-and-unsupported-errors
branch
from
e32ca9a to
4cae09f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BYclause withASC/DESCsorting (single and multiple columns)DISTINCT,ORDER BY) intoresult_processormodule for clearer separation of concernsORmatching insideORDER)EOIto grammar to ensure full input is consumed, preventing silent ignore of unsupported clauses likeSKIP/LIMIT"Unsupported feature: SKIP. Supported clauses: MATCH, WHERE, RETURN, ORDER BY.")Test plan
cargo test— 83 tests pass (14 new)cargo clippy --all-targets— no warnings🤖 Generated with Claude Code