fix: correct file-contains check logic (was inverted)#37
Merged
Conversation
The `contains` parameter was passed as `false`, causing file-contains to verify that the string is NOT present instead of verifying it IS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that file-contains correctly checks string presence (not absence) through the full evaluate_check dispatch path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file-containscheck was passingfalsetocheck_file_content, causing it to verify the string is NOT present instead of verifying it IScontainsparameter fromfalsetotrueTest plan
cargo clippyclean🤖 Generated with Claude Code