Skip to content

Support /*!no*/ comments syntax to fix issues #2#9

Open
leiming wants to merge 2 commits intosongsiqi:masterfrom
leiming:fix-issues-2
Open

Support /*!no*/ comments syntax to fix issues #2#9
leiming wants to merge 2 commits intosongsiqi:masterfrom
leiming:fix-issues-2

Conversation

@leiming
Copy link

@leiming leiming commented Sep 24, 2016

提供 /*!no*/ 的注释语法,用于支持less-loader

请容我解释一下为何在px2rem内部兼容,而不是去修复 webpack 或者 less-loader:

必须通过 ! 兼容 Less.js 的 source-map ,而在 webpack loader 体系不能传递 !,这就陷入一个死循环。

我承认这个 PR 不是最优雅的做法,但在不修改 YUI Compress 标准,又不变化 Webpack 1.x 体系的前提下,在内部支持可能是代价最小却能解决实际问题的做法。

@songsiqi @Jinjiang 怎么看 ^_^?

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling c5c269e on leiming:fix-issues-2 into 20e30fa on songsiqi:master.

@leiming
Copy link
Author

leiming commented Sep 24, 2016

Fix #2 vuejs/vue-loader#227

@xiaoai7904
Copy link

可以试试把px更换为PX,我在react 项目中使用了该方式是没有问题的,希望对你有所帮助

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants