lib: check hostname in resolver_resolve#26
Open
inspurSDN wants to merge 1 commit intosonic-net:frr/7.5from
Open
lib: check hostname in resolver_resolve#26inspurSDN wants to merge 1 commit intosonic-net:frr/7.5from
inspurSDN wants to merge 1 commit intosonic-net:frr/7.5from
Conversation
resolver_resolve should check hostname is null or not. if ares_gethostbyname() get null hostname string, the hostname string will access a null pointer and crash.
Author
|
@lguohan could you help to review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolver_resolve should check hostname is null or not.
if ares_gethostbyname() get a null hostname string, it will access a null pointer and crash.
test result:
trace code:
