[frr-10.0.1] Debug code for route-map RM_SET_SRC missing#42
Draft
jimmyzhai wants to merge 1 commit intosonic-net:frr-10.0.1from
Draft
[frr-10.0.1] Debug code for route-map RM_SET_SRC missing#42jimmyzhai wants to merge 1 commit intosonic-net:frr-10.0.1from
jimmyzhai wants to merge 1 commit intosonic-net:frr-10.0.1from
Conversation
jimmyzhai
commented
Mar 28, 2025
jimmyzhai
commented
2. Print dnode xpath around dnode_create 3. Add mutex lock in lyd_new_path 4. Find dnode for xpath having RM_SET_SRC with value 10.1.0.32 and cache it, then check the same dnode in mgmt_txn_prepare_config
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
yxieca
reviewed
Mar 28, 2025
| !strcmp("/frr-route-map:lib/route-map[name='RM_SET_SRC']/entry[sequence='10']/set-action[action='frr-zebra-route-map:src-address']/rmap-set-action/frr-zebra-route-map:ipv4-src-address", xpath)) { | ||
| mprotect(dnode->schema, sizeof(dnode->schema), PROT_READ); | ||
| rm_set_src_node = dnode; | ||
| free(xpath); |
There was a problem hiding this comment.
free should be outside the if block, else there is leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.