[build] Add go mod tidy before go mod vendor for Go 1.24 compat#157
Open
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Open
[build] Add go mod tidy before go mod vendor for Go 1.24 compat#157rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Conversation
Go 1.24 (shipped in Debian Trixie) is stricter about module graph consistency. Running `go mod vendor` without `go mod tidy` first fails with module resolution errors when the go.mod was written for an older Go version. Add `go mod tidy` before `go mod vendor`. This is backward compatible — on Go 1.21 (bookworm) it is a no-op. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[agent]
Add
go mod tidybeforego mod vendorin Makefile for Go 1.24 compatibility.What I did
Added
$(GO) mod tidybefore the$(GO) mod vendorcall in the Makefile.Why I did it
Go 1.24 (shipped in Debian Trixie) enforces stricter module graph consistency. When
go.modspecifies an older Go version but the build runs under Go 1.24,go mod vendorfails with module resolution errors unlessgo mod tidyruns first.How I verified it
Successfully built sonic-mgmt-framework under a Trixie slave container with Go 1.24.
On bookworm (Go 1.21),
go mod tidyis a no-op — no behavior change.Type of change