Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
Signed-off-by: Ben Levi <belevi@nvidia.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
benle7
force-pushed
the
change_sed_password
branch
from
9339915 to
3aec3c1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
previously approved these changes
Jan 11, 2026
liat-grozovik
previously approved these changes
Feb 15, 2026
Contributor
Author
Contributor
|
i see the there are requested change on the HLD. can we get consensus on the HLD? @judyjoseph , @bhouse-nexthop |
Contributor
Author
|
There are CR comments from @bhouse-nexthop |
Signed-off-by: Ben Levi <belevi@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 23, 2026
DavidZagury
reviewed
Mar 25, 2026
| try: | ||
| min_len = self.get_min_sed_password_len() | ||
| max_len = self.get_max_sed_password_len() | ||
| if len(new_password) < min_len or len(new_password) > max_len: |
There was a problem hiding this comment.
Is the only limitation on password the length? can it be any char?
Contributor
Author
There was a problem hiding this comment.
We are not aware to chars limitation. It can be a platform-specific limitation if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#2171
Description
I added BaseSedMgmt to provide support for changing/resetting the SED password.
It will be used by the new relevant CLIs.
Motivation and Context
We want to be able to change and reset the SED password via SONiC CLI.
How Has This Been Tested?
config sed change-password -p PASSWORD
config sed reset-password
Additional Information (Optional)