[action] [PR:168] Adding support for wildcard CN matching during client cert authentication#177
Merged
mssonicbld merged 1 commit intosonic-net:202511from Jan 15, 2026
Conversation
…tion Microsoft ADO ID: 36341347 This PR enables the restapi container (acting as a REST API server) to match Common Names (CNs) provided in the client certificate against trusted wildcard CNs during authentication. **Note 1:** Exact matching is still supported. **Note 2:** `*` can only appear at the beginning of a trusted CN. Examples: `*.example.com` matches `one.example.com` and `two.one.example.com`, but it does not match `example.com` or `example.com.edu` (wildcard matching). `example.com` only matches `example.com` (exact matching). Unit tests are also included in this PR to verify the expected behavior. For unit tests, trusted CNs are `test.client.restapi.sonic`, `*.example.sonic`, and `*test.sonic`. For each unit test, we generate a new client certificate and sign it with the self-signed certificate under `cert/client/`.
Author
|
Original PR: #168 |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft ADO ID: 36341347
This PR enables the restapi container (acting as a REST API server) to match Common Names (CNs) provided in the client certificate against trusted wildcard CNs during authentication.
Note 1: Exact matching is still supported.
Note 2:
*can only appear at the beginning of a trusted CN.Examples:
*.example.commatchesone.example.comandtwo.one.example.com, but it does not matchexample.comorexample.com.edu(wildcard matching).example.comonly matchesexample.com(exact matching).Unit tests are also included in this PR to verify the expected behavior. For unit tests, trusted CNs are
test.client.restapi.sonic,*.example.sonic, and*test.sonic. For each unit test, we generate a new client certificate and sign it with the self-signed certificate undercert/client/.