Fix WS-2018-0594 potential non-random UUIDs security issue

[xumia]

A vulnerability was found in github.com/satori/go.uuid through version v1.2.0. The UUID random generator uses Read() function which has fewer bytes than asked and might cause potential non-random UUIDs.

See advisory for vulnerability details
From CERT: satori/go.uuid@75cca53

More detail alert info can be found on https://msazure.visualstudio.com/One/_componentGovernance/Networking-acs-buildimage/alert/4546641?typeId=5886163

Fix multiple-value uuid.NewV4() in single-value context issue.

[qiluo-msft]

lgtm. @sumukhatv could you help review?

[sumukhatv]

@xumia Did test/apitest.py pass with this change?

[xumia]

Test results:
test_vnet_name_mapping_logic (main.ra_client_positive_tests) ... ok

---

Ran 32 tests in 35.470s

OK

test_vrouter_not_created_all_verbs (main.ra_client_negative_tests) ... ok

---

Ran 23 tests in 24.653s

OK

[xumia]

@sumukhatv , thanks for your comment, there is an API change, fixed.

[xumia]

@sumukhatv , the test is based on the change: #81

[sumukhatv]

@sumukhatv , the test is based on the change: #81

Does it mean that we need to merge #81 for the tests to pass for this PR?

[xumia]

@sumukhatv , this PR does not have any dependencies on the PR #81, the PR is a general fix. The test steps in the readme do not work, it should be another issue.

[sumukhatv]

@prsunny for visibility

[sumukhatv]

All the tests are passing. Good to merge:

~/sonic-restapi/test$ python apitest.py
test_config_status_reset_get (main.ra_client_positive_tests) ... ok
test_config_status_reset_post (main.ra_client_positive_tests) ... ok
test_delete_config_tunnel_decap_tunnel_type (main.ra_client_positive_tests) ... ok
test_delete_encap (main.ra_client_positive_tests) ... ok
test_delete_vrouter (main.ra_client_positive_tests) ... ok
test_duplicate_vni (main.ra_client_positive_tests) ... ok
test_get_all_vlans (main.ra_client_positive_tests) ... ok
test_get_encap (main.ra_client_positive_tests) ... ok
test_get_members_per_vlan (main.ra_client_positive_tests) ... ok
test_get_neighbors_per_vlan (main.ra_client_positive_tests) ... ok
test_get_vlans_per_vnetid_1digitvlans (main.ra_client_positive_tests) ... ok
test_get_vlans_per_vnetid_4digitvlans (main.ra_client_positive_tests) ... ok
test_get_vrouter (main.ra_client_positive_tests) ... ok
test_guid_persistence (main.ra_client_positive_tests) ... ok
test_local_subnet_route_addition (main.ra_client_positive_tests) ... ok
test_patch_routes_drop_bm_routes_local (main.ra_client_positive_tests) ... ok
test_patch_routes_drop_bm_routes_tunnel (main.ra_client_positive_tests) ... ok
test_patch_update_routes_with_optional_args (main.ra_client_positive_tests) ... ok
test_post_config_tunnel_decap_tunnel_type (main.ra_client_positive_tests) ... ok
test_post_encap (main.ra_client_positive_tests) ... ok
test_post_ping (main.ra_client_positive_tests) ... ok
test_post_vrouter (main.ra_client_positive_tests) ... ok
test_routes_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_all_args_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_member_notagging_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_member_tagged_untagged_interop (main.ra_client_positive_tests) ... ok
test_vlan_member_tagging_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_neighbor_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_with_ippref_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_with_vnetid_all_verbs (main.ra_client_positive_tests) ... ok
test_vlan_wo_ippref_vnetid_all_verbs (main.ra_client_positive_tests) ... ok
test_vnet_name_mapping_logic (main.ra_client_positive_tests) ... ok

---

Ran 32 tests in 35.560s

OK
test_delete_config_tunnel_decap_tunnel_type_not_vxlan (main.ra_client_negative_tests) ... ok
test_delete_vlan_member_not_created (main.ra_client_negative_tests) ... ok
test_delete_vlan_neighbor_not_created (main.ra_client_negative_tests) ... ok
test_delete_vlan_with_dependencies (main.ra_client_negative_tests) ... ok
test_delete_vrouter_with_dependencies (main.ra_client_negative_tests) ... ok
test_get_config_tunnel_decap_tunnel_not_created (main.ra_client_negative_tests) ... ok
test_get_vlan_member_not_created (main.ra_client_negative_tests) ... ok
test_get_vlan_neighbor_not_created (main.ra_client_negative_tests) ... ok
test_get_vlans_per_vnetid_invalid_vlan (main.ra_client_negative_tests) ... ok
test_get_vlans_per_vnetid_invalid_vnet (main.ra_client_negative_tests) ... ok
test_patch_delete_routes_not_created (main.ra_client_negative_tests) ... ok
test_post_ping_invalid (main.ra_client_negative_tests) ... ok
test_post_vlan_mem_which_exists_tagged (main.ra_client_negative_tests) ... ok
test_post_vlan_mem_which_exists_untagged (main.ra_client_negative_tests) ... ok
test_post_vlan_neighbor_which_exists (main.ra_client_negative_tests) ... ok
test_post_vlan_which_exists (main.ra_client_negative_tests) ... ok
test_post_vrouter_malformed_arg (main.ra_client_negative_tests) ... ok
test_post_vrouter_which_exists (main.ra_client_negative_tests) ... ok
test_post_vrouter_without_vtep (main.ra_client_negative_tests) ... ok
test_vlan_neighbor_not_valid_ip (main.ra_client_negative_tests) ... ok
test_vlan_not_created_all_verbs (main.ra_client_negative_tests) ... ok
test_vlan_out_of_range (main.ra_client_negative_tests) ... ok
test_vrouter_not_created_all_verbs (main.ra_client_negative_tests) ... ok

---

Ran 23 tests in 24.663s

OK