Added CLI commands to configure Local Users' Passwords Reset feature#3302
Open
azmy98 wants to merge 3 commits intosonic-net:masterfrom
Open
Added CLI commands to configure Local Users' Passwords Reset feature#3302azmy98 wants to merge 3 commits intosonic-net:masterfrom
azmy98 wants to merge 3 commits intosonic-net:masterfrom
Conversation
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
cc9f2d9 to
860f804
Compare
azmy98
changed the title
azmy98
force-pushed
the
dev-reset-local-users-password
branch
7 times, most recently
from
b41277b to
40c6e2b
Compare
Collaborator
|
@azmy98 Can you please fix the conflicts and the build? |
dgsudharsan
requested changes
May 14, 2024
Collaborator
dgsudharsan
left a comment
dgsudharsan
left a comment
There was a problem hiding this comment.
Please add the output of new show command to description
show/main.py
Outdated
| data = [] | ||
|
|
||
| for key in hdrs: | ||
| data.append(feature_table.get(key, '').replace('\\n', '\n')) |
Collaborator
There was a problem hiding this comment.
Can you please clarify why do we need replace here? I don't see any other API doing this.
Author
There was a problem hiding this comment.
I used the same as the Banner 'show' command implementation: #3021
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
40c6e2b to
db4231a
Compare
Author
|
@dgsudharsan, The new commands are documented in the doc file. |
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
db4231a to
1d84e34
Compare
dgsudharsan
previously approved these changes
May 16, 2024
azmy98
force-pushed
the
dev-reset-local-users-password
branch
2 times, most recently
from
65294f4 to
039db9d
Compare
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
a2a14b2 to
c118910
Compare
…and display current configuration
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
c118910 to
bfc284a
Compare
Contributor
|
/azpw run Azure.sonic-utilities |
Contributor
|
@azmy98 , please fix build issue. |
Author
|
/azpw run Azure.sonic-utilities |
Collaborator
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Sep 16, 2024
Contributor
|
Please resolve conflict. |
| from utilities_common.db import Db | ||
|
|
||
|
|
||
| class TestLocalUsersPasswordsReset: |
Contributor
There was a problem hiding this comment.
could you add config db json for test as well? https://github.com/sonic-net/sonic-utilities/tree/master/tests
liuh-80
approved these changes
Dec 10, 2024
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added CLI commands for Local Users' Passwords Reset feature according to HLD: sonic-net/SONiC#1577
How I did it
Added CLI commands to:
How to verify it
Manual testing
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A