Skip to content

Conversation

@bhouse-nexthop
Copy link
Contributor

What I did

sonic-utilities should never call directly into libyang. All functionality it needs should be provided in sonic-yang-mgmt. This resolves issues when libyang changes API/ABI such as happened between libyang1 and libyang2, and again between libyang2 and libyang3.

Depends on sonic-net/sonic-buildimage#24414
Fixes sonic-net/sonic-buildimage#22385

How I did it

Removed calls to libyang and instead uses new functionality introduced in sonic-yang-mgmt.

Also installs both libyang1 and libyang3 for tests to maintain compatibility with both during the migration.

How to verify it

After sonic-net/sonic-buildimage#24414 merges observe test cases still pass.

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

N/A

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sonic-utilities should never call directly into libyang.  All
functionality it needs should be provided in sonic-yang-mgmt.  This
resolves issues when libyang changes API/ABI such as happened
between libyang1 and libyang2, and again between libyang2 and libyang3.

Depends on sonic-net/sonic-buildimage#24414
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Upgrade to libyang3

2 participants