Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions show/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,12 @@ def storm_control(ctx, namespace, display):

@storm_control.command('interface')
@click.argument('interface', metavar='<interface>',required=True)
def interface(interface, namespace, display):
@click.pass_context
def interface(ctx, interface):
# Get namespace from parent context
namespace = ctx.parent.params.get('namespace')

if multi_asic.is_multi_asic() and namespace not in multi_asic.get_namespace_list():
ctx = click.get_current_context()
ctx.fail('-n/--namespace option required. provide namespace from list {}'.format(multi_asic.get_namespace_list()))
if interface:
display_storm_interface(interface)
Expand Down
20 changes: 20 additions & 0 deletions tests/storm_control_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@
from utilities_common.db import Db
import config.validated_config_db_connector as validated_config_db_connector

show_storm_interface_output="""\
+------------------+-------------------+---------------+
| Interface Name | Storm Type | Rate (kbps) |
+==================+===================+===============+
| Ethernet0 | broadcast | 100000 |
+------------------+-------------------+---------------+
| Ethernet0 | unknown-unicast | 200000 |
+------------------+-------------------+---------------+
| Ethernet0 | unknown-multicast | 300000 |
+------------------+-------------------+---------------+
"""

class TestStormControl(object):
@classmethod
def setup_class(cls):
Expand Down Expand Up @@ -123,6 +135,14 @@ def test_show_storm(self):
print(result.output)
assert result.exit_code == 0

def test_show_storm_interface(self):
runner = CliRunner()
result = runner.invoke(show.cli, ["storm-control", "interface", "Ethernet0"])
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert result.output == show_storm_interface_output

@classmethod
def teardown_class(cls):
os.environ['UTILITIES_UNIT_TESTING'] = "0"
Expand Down
Loading