More optimized Smut Orc Camp by Phate4569 · Pull Request #284 · soolar/sl_ascend

Phate4569 · 2019-07-24T17:35:38Z

Added - Optimization for Smut Orc quest. In testing saved 10 turns without having the most effective skills.

Essentially a better attempt at "Brute Forcing" the Quest. Instead of relying on every 15th adv we try to play to our strengths in every combat and rely on getting the Non-Com more frequently.

I left in the every 15th non-com prep because it is more beneficial to newblets without lots of perms or shinies, an area that my method doesn't cover well. I figured this would be a good middle ground, and wouldn't be too detrimental to people with the aforementioned benefits.

…thout having the most effective skills.

…rue (avoids carryover from Smut Orc)

…rn off the +ML we are running rather than letting the effects time out.

jaspercb

I'm confused why the do ML/don't do ML logic is in postsool rather than presool (although the doML logic was there before you showed up :) ). In general I think this is promising but needs a little more polish. Comments attached.

RELEASE/scripts/postsool.ash

RELEASE/scripts/sl_ascend.ash

RELEASE/scripts/postsool.ash

jaspercb · 2019-07-26T15:42:32Z

RELEASE/scripts/sl_ascend/sl_combat.ash

+			else if(canUse($skill[Northern Explosion]))
+			{
+				return useSkill($skill[Northern Explosion]);
+			}


log a "oh no, we didn't have anything to use" message in red here please

Ah Yes, that is better for Debugging. Added.

This one line should stay red.

…ow in postsool Changed - Added delay counter to doML when removing Asdon Driving Intimidatingly Changed - Converted sl_useSpellsInOrcCamp from property to skill Changed - Added alert message when we can no tuse our preferred skills

…e Unexpectedly. Added - If sl_aggressiveBlechHouse is set true (default false) we will choose the option we are buffed for, otherwise pause with message alerting the user.

Phate4569 · 2019-07-29T18:42:54Z

Closes #217

soolar

Sorry for being more than a little slow to deliver feedback!

soolar · 2019-08-17T19:55:04Z

RELEASE/scripts/postsool.ash

+			}
+			if(0 < have_effect($effect[Drescher\'s Annoying Noise]))
+			{
+				uneffect(Drescher\'s Annoying Noise);


It's not worth using a SGEEA to uneffect this or anything after it here imo. Drinking Recklessly and Ur-Kel's make sense since they're free to uneffect, but the other stuff doesn't.

I don't know if I agree, especially if the player does not have Asdon Martin.

Smut Orcs have a base 69 HP.
+ML adds +1 HP per level, subtracts 1 per negative level.
Blech House manifests when 15 Orc worth of damage is done, capped at 5x per kill.

So without buffs you need to do:
2x = 138
3x = 207
4x = 276
5x = 345

Letting both of these ride, no Asdon (HP=89):
2x = 178
3x = 267
4x = 356
5x = 445

Dropping these AND having the Asdon Active (HP=44):
2x = 88
3x = 132
4x = 176
5x = 220

Without knowing exactly what each player has for equips and permed from the list I can't quantify this into turn savings, but by eliminating those (if we can) it makes it more low-IOTM and low-skill friendly IMO, and still benefits high-IOTM and high-PERM players, especially running in a non-MP friendly path.

Would maybe "sl_aggressiveML = false" on the relay be better and let the user decide?

Actually maybe you're right, but it's still not as important as being able to uneffect on the trail when needed. It's okay for people swimming in SGEEAs or without access to Transcendent Olfaction though (either because they don't have it or they're on a path without normal skill access), so how about with this conditional:

if(!sl_have_skill($skill[Transcendent Olfaction]) || item_amount($item[soft green echo eyedrop antidote]) > 5)

around the block with uneffecting the things that take sgeeas?

soolar · 2019-08-17T19:57:48Z

RELEASE/scripts/sl_ascend/sl_combat.ash

+			{
+				return useSkill($skill[Stuffed Mortar Shell]);
+			}
+			else if(canUse($skill[Saucegeyser]))


Needs to be canUse($skill[Saucegeyser], false) because Saucegeyser can be used multiple times in one combat.

Done, on all counts.

I'm not to familiar with this, what does the ", false" signify?

useSkill and canUse accept an optional boolean that defaults to true, which basically says "this skill can only be used once per combat"

RELEASE/scripts/sl_ascend/sl_combat.ash

soolar · 2019-08-17T20:00:07Z

RELEASE/scripts/postsool.ash

-			// Catch when we leave Smut Orc
-			if(0 < have_effect($effect[Driving Intimidatingly]))
+			// Catch when we leave Smut Orc, allow for being "side tracked" buy delay burning
+			if((0 < have_effect($effect[Driving Intimidatingly])) && (debuffAsdonDelay > 1))


I don't think this will ever actually be anything but 0 since it's not persistent between runs of of postsool.

Hmm, that is a problem. I was trying to make it so that the variable would be persistent. If I set_property then it gets overwritten each time sl_ascend is rerun correct? So if the script stops (ie. Blech House) and then immediately goes into a delay-turn due to Kramco or Vote, it will debuff.

soolar · 2019-08-17T20:02:43Z

RELEASE/scripts/sl_ascend.ash

+		else
+		{
+			print("If we encounter Blech House when we are not expecting it we will stop.", "blue");
+			print("Currently setup for Myst/Spell Damage, option 2: Blast it down with a spell", "red");


This should probably be blue too. Although I'm not sure if we really need to print anything here at all?

In case Blech House does happen they know what option is spec'd so they can manually choose for maximum effect.

soolar · 2019-08-17T20:05:44Z

RELEASE/scripts/sl_ascend.ash

 		buffMaintain($effect[Song of Sauce], 150, 1, 1);

-		if(get_property("sl_aggressiveBlechHouse").to_boolean())
+		if(get_property("sl_beta_test").to_boolean())


Eh, I'd rather this be separate from beta test. I still think the better behavior is stopping when we encounter blech house and aren't expecting it, personally, since that means we might actually get reports of the issue instead of it going unnoticed.

So add back in "sl_aggressiveBlechHouse" or make it always stop regardless of mode? I'd vote for the former personally?

Eh I guess I'm fine with either of those, although I'd kind of prefer to avoid cluttering the preferences. But it's probably worth having a preference in this case, I guess?

RELEASE/scripts/postsool.ash

rugrat added 6 commits July 24, 2019 13:24

Added - Optimization for Smut Orc quest. In testing saved 10 turns wi…

d2e4440

…thout having the most effective skills.

Forgot to remove a section, noticed it while creating the pull request

edfd6b9

Added - Remove Ur-Kel's to Orc Chasm

85aa35c

Added - Turn off "doML" in postsool

e4803fa

Fixed - Make sure to remove "Driving Intimidatingly" when "doML" is t…

b59e764

…rue (avoids carryover from Smut Orc)

Added - added "removeML" to postsool for times we want to actively tu…

94c7b98

…rn off the +ML we are running rather than letting the effects time out.

jaspercb reviewed Jul 26, 2019

View reviewed changes

rugrat added 4 commits July 26, 2019 12:36

Added - Option added to relay to not pause if we encounter Blech Hous…

b674678

…e Unexpectedly. Added - If sl_aggressiveBlechHouse is set true (default false) we will choose the option we are buffed for, otherwise pause with message alerting the user.

Fixed - Forgot .to_boolean() on sl_aggressiveBlechHouse check

26c1182

Fixed - Linked Smut Orc to Beta Testing.

7f99e20

Phate4569 added 3 commits August 7, 2019 09:25

Forgot $effect on removeML

fb7bce7

Changed Maximizer to work with new default maximizer

20b4277

Non-essential smoothing of asdon debuffing logic

489b5e6

soolar requested changes Aug 17, 2019

View reviewed changes

Phate4569 added 3 commits August 19, 2019 11:06

Removed .to_int() and altered debuff logic

71bb354

Added ,false to skill checks.

f5e4cb0

Adding ", false" to skills.

bd2a3f4

macgregor mentioned this pull request Sep 19, 2019

More optimized Smut Orc Camp loathers/autoscend#54

Closed

Conversation

Phate4569 commented Jul 24, 2019

Uh oh!

jaspercb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Phate4569 commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soolar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Phate4569 commented Jul 29, 2019 •

edited

Loading