Oil Peak and Tavern Optimization and Grouping#285
Oil Peak and Tavern Optimization and Grouping#285Phate4569 wants to merge 9 commits intosoolar:masterfrom Phate4569:Oil-Peak-And-Tavern-Optimization-With-Grouping
Conversation
…evaluate end of the Quest (Thanks jaspercb!)
…paro). Also removed useless DEBUG line I copied over from my test version.
|
https://help.github.com/en/articles/closing-issues-using-keywords for proper usage |
RELEASE/scripts/sl_ascend.ash
Outdated
| set_property("sl_oilpeak", "finished"); | ||
|
|
||
| // Reset basline | ||
| set_property("sl_maximize_baseline", ""); |
There was a problem hiding this comment.
This property should only be touched by the user. I think you're looking for resetMaximize()
| sl_change_mcd(11); | ||
|
|
||
| // Set baseline to force maximizer usage | ||
| set_property("sl_maximize_baseline", "1000ml 100max"); |
There was a problem hiding this comment.
Again, don't fiddle with this property automatically.
There was a problem hiding this comment.
I added this one (and the one previously) because maximize didn't seem to be setting anything at all until I added a value.
There was a problem hiding this comment.
An addToMaximize call didn't work? Did you have sl_maximize_baseline set to disabled or something? Either way you can't do this, since it would override a user's personal settings, if any.
| handleFamiliar("item"); | ||
|
|
||
| // Reset baseline again, just in case | ||
| set_property("sl_maximize_baseline", ""); |
RELEASE/scripts/sl_ascend.ash
Outdated
| print("Checking to see if we should do the tavern while we are running high ML.", "green"); | ||
| set_property("sl_forceTavern", true); | ||
|
|
||
| // Remove Driving Wastefully if we had it |
There was a problem hiding this comment.
Why bother? It's not like it stops us from getting another buff when we actually want to get one, and it's harmless.
There was a problem hiding this comment.
Somehow it does, possibly the Asdon Buff function is broken? If I don't put this in it keeps driving Wastefully when it goes to the the next area. I found this while trying to figure out why it wasn't buffing Tavern properly.
3 participants
Replaces my Previous Pull Request for a similar issue. I re-re-did it since there have been so many changes
Added - Oil Peak and Tavern Optimization and Grouping
In testing saved 8 Adv on Oil Peak. The Tavern is harder to quantify.