Conversation
25010c3 to
2a88517
Compare
… added a new StarPlot.attitude_changed
… utils.log_exception
…co_view.py and aperoll/proseco_data.py
2a88517 to
ede1632
Compare
… aperoll.widgets.parameters into a new module aperoll.widgets.line_edit and aperoll.utils
… slot_included. While at it, also renamed signal include_star -> star_included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is basically a refactoring of the current aperoll app to evaluate difficult star views.
The only major change in the UI is the addition of the
ProsecoParamsclass. This is a small json editor where one can change most of the standard arguments to proseco.The other changes are a restructuring of the code. The reason for this is that the code was very hard to understand. It was easier to write from scratch. Roughly, these changes are:
ProsecoView,ProsecoData,ProsecoParams) replace theMainWindowandParametersclasses. Basically the same functionality in a better structure.ProsecoDataclass to deal with calls to proseco and sparkles, cache the results and export to file. This used to be inMainWindow.Parametersclass intoProsecoParamsMainWindowandParametersclasses into the newProsecoViewclass.Doing this, I found cases where Qt signals would cause infinite recursion and fixed that. In other cases, the logic in the signals was not clear (a signal triggers a signal, which triggers another, so the dependence is not clear and makes the code hard to understand).
Another change is the addition of the
AttitudeWidget(which could have been called QuaternionWidget) used to display a quaternion in different representations (and properly handle the signals when contents change).Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.