Merged
Conversation
javierggt
force-pushed
the
telemetry-view
branch
from
8553624 to
0680f4f
Compare
|
Does this require the aca_view PR or does it just do nothing without it? |
Contributor
Author
The aca_view PR requires this one. This one requires nothing. Aca_view creates a If you look at the diffs, this PR only adds files. The changes to existing files are clearly ruff-related. That means that, whatever this PR adds, it is not used in any existing aperoll application. That also means that the telemetry view could be an aca_view class. Maybe the others too. |
|
Thanks yeah - I was trying to figure out what an "interface impact" really means in the context of optionally supporting a new feature! |
jeanconn
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds classes to use aperoll within aca_view. No change in this PR affects the basic use case of aperoll. Considering that it is self-contained, and that development on it slowed down after March, I think we should just merge it as an experimantal feature.
This is a huge PR. I'm pretty sure there will be more changes, but it "works" as it stands, and if it doesn't it is not a problem. It is better to take this as the status quo moving forward and fix/improve from here.
Interface impacts
Requires sot/aca_view/pull/197 for this to be used from aca_view .
Testing
Unit tests
Functional tests
No functional testing.