Fix problems with time order of ephemeris data#285
Merged
Conversation
jeanconn
reviewed
Dec 9, 2025
55 tasks
jeanconn
approved these changes
Jan 5, 2026
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue that full-resolution ephemeris data from a cheta-sync maintained archive include data that are both duplicated and not in strict time order.
The raw ephemeris HDF5 archive files are non-monotonic because the archive FITS files are overlapping and have duplicate times. Typically new ephemeris files come out each 7 days and cover many weeks of data (e.g. about 10 weeks for the predictive EPHEM 0 files.
The HDF5 files on HEAD have TIME.quality set to bad for the duplicate times, so this code is not strictly required there. But for archives maintained with cheta_sync, the quality codes are not back-updated when new data appear, causing problems.
Fixes #245
Requires
None, but this should be considered as a required dependency for sot/xija#150.
cc: @matthewdahmer @christian-anderson @jzuhone
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
Additional functional testing in the included notebook.