Add scheduled obsid to commands, states, observations#368
Open
Add scheduled obsid to commands, states, observations#368
Conversation
jzuhone
approved these changes
Nov 18, 2025
55 tasks
ab84d72 to
eaa8bad
Compare
Version 3 now includes scheduled obsid
This option makes no sense and has not ever been tested. The only meaningful scenario for updating the flight cmds archive is the default None.
Does not change effective results but this fixes a unit test issue in command ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses a long-standing issue that the kadi
obsidreflects the as-run loads. In the case of SCS-107, the kadiobsidmatches telemetry but does not allow easily connecting back to planned observations (in particular the vehicle-only parts that still run along with all the planning products).During backstop ingest, this PR adds a new command row with
type=LOAD_EVENT tlmsid=OBSIDwhich is a copy of eachtype=MP_OBSID tlmsid=COAOSQIDcommand, but with the SCS slot decreased by 3 so that 131, 132, 133 => 128, 129, 130. In effect this puts "scheduled ObsID" commanding into the vehicle loads so after an SCS-107 they persist.This PR also adds a new
conf.matching_block_sizeconfiguration variable. This is mostly useful for testing and development and is not intended as something users would change.Dev Note
There is an issue right now with deployment and options for back-updating the commands archive. Because matching command blocks (500 commands) are required at the interface between archive and new (backstop) commands, conflicts arise and if there is a mismatch (old archive / new code or vice versa).
Interface impacts
type=LOAD_EVENT tlmsid=OBSIDcommands.obsid_schedto the output ofget_observations().obsid_schedto query the scheduled ObsID.conf.matching_block_sizeconfiguration variable.Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.