Add Community Created Mods and Fix Replay Filename Issue#153
Open
dnl-nash wants to merge 4 commits intosoundmud:masterfrom
Open
Add Community Created Mods and Fix Replay Filename Issue#153dnl-nash wants to merge 4 commits intosoundmud:masterfrom
dnl-nash wants to merge 4 commits intosoundmud:masterfrom
Conversation
… War mods, along with Tang Campaign Removed nonfunctional crazymod directory
…y not the best way to do this, but I'm still learning python, so please excuse any formatting/other issues
Added documentation for Crazy Mod
Owner
|
Thanks for your pull request. I cannot include it as is, but I'll do my best to take it into account. Don't hesitate to send your pull requests or issues more "atomically". No need to group them. First, about the mods, I am trying to isolate them from the code and have them in packages. Please try this experimental feature if you want:
To undo the change:
That's all for now. More later. |
Owner
|
I will include a variant of your patch about replay files. I removed some redundancy and replaced the () which are not a tuple (it lacks a comma when there is one item) with a [] which doesn't need a comma. It was working anyway but it spelled the name instead of reading the name. I might include the notice about pip and Linux later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.