Fix meadow loss when upgrading to land-consuming buildings#160
Open
wuyeyoumin wants to merge 1 commit intosoundmud:masterfrom
Open
Fix meadow loss when upgrading to land-consuming buildings#160wuyeyoumin wants to merge 1 commit intosoundmud:masterfrom
wuyeyoumin wants to merge 1 commit intosoundmud:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
When a unit is upgraded into a building that consumes meadow land,
the meadow is removed from the world but not recorded in the new
building's
building_landfield.As a result, when the upgraded building is destroyed, the meadow
cannot be restored and is permanently lost.
Fix
This PR preserves or assigns
building_landduring the upgradeprocess so that buildings created via
upgrade_tocorrectly restoretheir meadow when destroyed.
The fix is consistent with the normal building construction logic and
does not affect buildings that do not consume meadow.
I encountered this issue during gameplay and verified that this change fixes the problem.