This repository was archived by the owner on Mar 2, 2019. It is now read-only.
Conversation
Without vertical align, text would be flush to the top such that it would seem to be off center with any buttons (if any) in the same row. Without margin-bottom, buttons would have touching borders. Added these changes to _global.scss, since rows in tables may occur throughout the site. _global.scss seemed to be the most semantically appropriate location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make rows prettier with vertical alignment and a small bottom margin.
Granted, this is completely unnecessary given the migration to cadet, but it did help me get to know the project a little. Also helps me get a feel of the workflow.
(left: original, right: this change)
Without vertical align, text would be flush to the top such that it would seem to be off center with any buttons (if any) in the same row.
Without margin-bottom, buttons would have touching borders.
Added these changes to _global.scss, since rows in tables may occur throughout the site. _global.scss seemed to be the most semantically appropriate location.