Skip to content

chore: cleanup clients/v1 proto formatting #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: cleanup clients/v1 proto formatting #103

wants to merge 1 commit into from

Conversation

kalanchan
Copy link
Contributor

addresses #89 (comment) by adding a blank line between RPCs for consistency and styling

Test plan

CI

@kalanchan kalanchan requested a review from a team as a code owner August 1, 2025 19:34
@kalanchan kalanchan changed the title chore: cleanup clients/v1 proto chore: cleanup clients/v1 proto formatting Aug 1, 2025
@kalanchan kalanchan requested a review from unknwon August 1, 2025 19:34
@kalanchan
Copy link
Contributor Author

joe please stamp

@kalanchan
Copy link
Contributor Author

@unknwon hurry up!

unknwon
unknwon suggested changes Aug 2, 2025
View reviewed changes
Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup but I think you completely miss the actual change that was asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@unknwon unknwon unknwon requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalanchan @unknwon