Skip to content

fix(mcp): check args before use in mcp #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burmudar merged 1 commit into from
Dec 9, 2025
Merged

fix(mcp): check args before use in mcp #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions cmd/src/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,21 @@ var mcpFlagSet = flag.NewFlagSet("mcp", flag.ExitOnError)

func init() {
commands = append(commands, &command{
flagSet: mcpFlagSet,
handler: mcpMain,
flagSet: mcpFlagSet,
handler: mcpMain,
usageFunc: mcpUsage,
})
}

func mcpUsage() {
fmt.Println("The 'mcp' command exposes MCP tools as subcommands for agents to use.")
fmt.Println("\nUSAGE:")
fmt.Println(" src mcp list-tools List available tools")
fmt.Println(" src mcp <tool-name> schema View the input/output schema of a tool")
fmt.Println(" src mcp <tool-name> <flags> Invoke a tool with the given flags")
fmt.Println(" src mcp <tool-name> -h List the available flags of a tool")
}

func mcpMain(args []string) error {
fmt.Println("NOTE: This command is still experimental")
apiClient := cfg.apiClient(nil, mcpFlagSet.Output())
Expand All @@ -31,21 +42,21 @@ func mcpMain(args []string) error {
return err
}

if len(args) == 0 {
mcpUsage()
return nil
}

subcmd := args[0]
if subcmd == "list-tools" {
fmt.Println("The following tools are available:")
for name := range tools {
fmt.Printf(" • %s\n", name)
fmt.Printf(" %s\n", name)
}
fmt.Println("\nUSAGE:")
fmt.Printf(" • Invoke a tool\n")
fmt.Printf(" src mcp <tool-name> <flags>\n")
fmt.Printf("\n • View the Input / Output Schema of a tool\n")
fmt.Printf(" src mcp <tool-name> schema\n")
fmt.Printf("\n • List the available flags of a tool\n")
fmt.Printf(" src mcp <tool-name> -h\n")
fmt.Printf("\n • View the Input / Output Schema of a tool\n")
fmt.Printf(" src mcp <tool-name> schema\n")
fmt.Println(" src mcp <tool-name> schema View the input/output schema of a tool")
fmt.Println(" src mcp <tool-name> <flags> Invoke a tool with the given flags")
fmt.Println(" src mcp <tool-name> -h List the available flags of a tool")
return nil
}
tool, ok := tools[subcmd]
Expand Down
Loading