Use the sourcemeta_enable_simd() in Blaze
#148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm making SIMD flags opt-in to make it easier to release cross-platform binaries for tools like the JSON Schema CLI (as some target machines will not support SIMD). While we don't use SIMD directly, auto-vectorisation does, and saw issues in the wild with the JSON Schema CLI binaries not working on certain machines. Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
@jviotti This looks fine to me. Any reason not to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making SIMD flags opt-in to make it easier to release cross-platform
binaries for tools like the JSON Schema CLI (as some target machines
will not support SIMD).
While we don't use SIMD directly, auto-vectorisation does, and saw
issues in the wild with the JSON Schema CLI binaries not working on
certain machines.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com