Merged
Conversation
sozercan
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refines the Copilot CLI UX by removing internal conversation identifiers from human-facing output, improving --no-input readability, and adding a lightweight terminal spinner during Copilot requests.
Changes:
- Stop emitting conversation IDs in human/plain outputs (keep them available via
--output json). - Adjust
--no-inputoutput to omit the chat-styleCopilot:prefix while preserving relevant metadata. - Add a terminal spinner for Copilot requests and update docs/tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| internal/commands/copilot/copilot.go | Removes conversation ID printing, hides conversation IDs in non-JSON output, adds --no-input formatting tweak, and introduces a spinner. |
| internal/commands/copilot/copilot_test.go | Updates expectations to ensure conversation IDs stay hidden and adds coverage for --no-input and spinner behavior. |
| docs/copilot.md | Updates CLI documentation to direct users to JSON output for inspecting conversation IDs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+279
to
+282
| func startCopilotSpinner(ctx *commands.Context, w io.Writer) func() { | ||
| if ctx.Verbose || !stderrIsTerminal() { | ||
| return func() {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-inputplain output formattingWhy
Human/plain output was exposing conversation IDs and the
--no-inputexperience had awkward formatting. These changes make the CLI output cleaner and more consistent for interactive and non-interactive use.Impact
--no-inputresults are easier to read in plain modeRoot Cause
The command path mixed internal conversation metadata into human-facing output, and the plain-mode
--no-inputformatting did not present the response cleanly.Validation
go test ./... -count=1go vet ./...make build