NASA Challenge_[@elementrobotics]_[LunarSim] (closes space-ros/demos#50)#36
Open
mazm0002 wants to merge 2 commits intospace-ros:rollingfrom
Open
NASA Challenge_[@elementrobotics]_[LunarSim] (closes space-ros/demos#50)#36mazm0002 wants to merge 2 commits intospace-ros:rollingfrom
mazm0002 wants to merge 2 commits intospace-ros:rollingfrom
Conversation
Contributor
|
Hi @mazm0002 . I'd like to prepare this issue for merging together with the demo. I tried to make the following changes to make the PR comply with our process. Can you please:
|
The demonstrations now include a lunar simulation. This commit adds a documentation page to the website describing how the simulation can be built and run.
50476d8 to
1010635
Compare
Author
|
Hi @ivanperez-keera, thanks for helping in getting this merged! I've squashed the commits and changed the message to the suggested one. Let me know if anything else needs to be fixed here or with the demo. |
Contributor
|
Thank you @mazm0002 for acting so quickly on this. I'll review the associated PR in the demos repo and post any other requests for changes there. It makes sense to merge things first in the demos repo and then here, just so that we don't have documentation that points to a demo that is not merged yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on space-ros/demos#51
This PR adds instructions to run the spaceROS Lunar Sim demo as well as extensive documentation on how users can integrate their own Digital Elevation Models (DEMs), Ephemeris data and textures.