Skip to content

Fix CI Ubuntu version (#50) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EzraBrooks wants to merge 1 commit into from
Closed

Fix CI Ubuntu version (#50) #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/spaceros.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ on:

jobs:
test:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: 3.12

- name: Install dependencies with pip
run: |
Expand All @@ -28,7 +28,7 @@ jobs:
run: make test

deploy:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
permissions:
contents: write
needs: test
Expand All @@ -40,7 +40,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: 3.12

- name: Install dependencies with pip
run: |
Expand Down
2 changes: 1 addition & 1 deletion docker/image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# docker build -f docker/image/Dockerfile .

FROM ubuntu:focal
FROM ubuntu:noble

ARG user=rosindex
ARG uid=1000
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
doc8==0.8.1
docutils==0.16.0
pip==22.0.2
Copy link
Member Author

@EzraBrooks EzraBrooks Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unpinned pip because in CI this is coming from setup-python in the first place. This is misleadingly placed imo

sphinx==4.3.2
sphinx-copybutton==0.4.0
sphinx-multiversion==0.2.4
Expand Down
Loading