Bugfix: Handling Slack messages with file attachments#159
Open
egenvall wants to merge 9 commits intospacedriveapp:mainfrom
Open
Bugfix: Handling Slack messages with file attachments#159egenvall wants to merge 9 commits intospacedriveapp:mainfrom
egenvall wants to merge 9 commits intospacedriveapp:mainfrom
Conversation
Member
|
@tembo review please |
|
@jamiepine I'm working on your request now and will update you when I'm done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently Slack subtype messages are ignored, but we need to allow
FileSharetype messages to parse attachments sent in chat.Slack file assets are also private, so the bot needs header auth to properly download them.
Slack also uses some redirects which strips the Auth Header - so we need to manually deal with the redirects for Slack.
Outcome
Before: Sending a message like "Analyze this image" would hang and yield no response.
With subtype support: The message is parsed but errors out on provider API level due to no headers
With Subtype and Header: The asset is successfully parsed and accessed by the bot and can be processed and the outcome returned in Slack.
Input Example 1
Input Example 2
"Ingest and analyze this CSV: {csv file}".