-
Notifications
You must be signed in to change notification settings - Fork 182
Process sandbox: kernel-enforced filesystem containment for shell/exec #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,014
−377
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4bbdd63
Implement OS-level sandboxing for subprocesses using bubblewrap and s…
jamiepine 36bfea0
Merge branch 'main' into sandboxing
jamiepine cbdb245
merge main into sandboxing, resolve AgentDeps field conflicts
jamiepine 2788ba2
address review feedback: sandbox and send_file hardening
jamiepine b0ae7ae
fix test compilation: add sandbox field to test AgentDeps constructors
jamiepine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: spacedriveapp/spacebot
Length of output: 305
🏁 Script executed:
Repository: spacedriveapp/spacebot
Length of output: 12028
Documentation claim about SPACEBOT_DEPLOYMENT=hosted sandbox enforcement is unsupported.
While
SPACEBOT_DEPLOYMENT=hostedis properly detected in the codebase (used to enforce API bind settings), there is no implementation that forces sandboxmode = "enabled"when hosted is set. The codebase searches show hosted-aware logic only for API configuration, not sandbox mode.The design doc references "platform boot script forces mode", suggesting this is external infrastructure enforcement rather than app-level logic. Either clarify in the user-facing documentation that this is platform-enforced externally (not in the app config), or remove the claim if it's not actually guaranteed on the hosted platform.
🤖 Prompt for AI Agents