Allow loading Python APMs installed as packages (directories)#58
Open
kivkiv12345 wants to merge 1 commit intomasterfrom
Open
Allow loading Python APMs installed as packages (directories)#58kivkiv12345 wants to merge 1 commit intomasterfrom
kivkiv12345 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bypasses the check for a
.pysuffix if thedirentis a directory. Allowing us to load Python APMs which are directories with an__init__.py.I suspect the
.pysuffix check was added to avoidload_py()printing errors for normal.soAPMs.My preferred solution would be to only print errors for APM candidates that can neither be loaded as a normal nor Python APM.
But this solution works fine for the foreseeable future.