statusline api implemented by edvardxyz · Pull Request #24 · spaceinventor/slash

edvardxyz · 2026-03-27T09:57:33Z

No description provided.

Copilot

Pull request overview

Adds a statusline facility to the slash interactive console, reserving the terminal’s bottom row for persistent status items (normal/warn/error) rendered during refresh.

Changes:

Introduces a new statusline module (slash_statusline_set/remove/count/render) with ANSI color themes.
Integrates statusline activation/deactivation into terminal configuration and the main refresh loop (scroll-region reservation + redraw).
Extends struct slash with statusline terminal-state tracking and adds a slash_sigwinch() helper.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`src/statusline.c`	Implements global statusline item storage and rendering logic.
`include/slash/statusline.h`	Declares the statusline public API and `slash_statusline_set` macro wrapper.
`src/slash.c`	Activates/deactivates a reserved bottom row, redraws statusline on refresh, and updates read() to retry on EINTR.
`include/slash/slash.h`	Adds statusline fields to `struct slash` and exposes `slash_sigwinch()`.
`meson.build`	Adds `src/statusline.c` to the build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T07:54:19Z

src/slash.c

+			/* Activation moved cursor; re-run refresh at new position */
+			return slash_refresh(slash, printtime);
+		}
+		struct winsize ws;
+		if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&
+		    ws.ws_row != slash->statusline_rows) {
+			slash_statusline_activate(slash);
+			return slash_refresh(slash, printtime);
+		}
+		char pos[16];
+		slash_write(slash, "\0337", 2);  /* DEC save cursor */
+		snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);
+		slash_write(slash, pos, strlen(pos));
+		slash_statusline_render(slash);
+		slash_write(slash, "\0338", 2);  /* DEC restore cursor */


slash_refresh() recurses unconditionally after calling slash_statusline_activate(). If slash_statusline_activate() returns early (e.g., ioctl(TIOCGWINSZ) fails), statusline_enabled stays false and this becomes infinite recursion / stack overflow. Consider making slash_statusline_activate() report success (e.g., return bool/int) and only re-run refresh when activation actually succeeded; otherwise continue without statusline.

Suggested change

/* Activation moved cursor; re-run refresh at new position */

return slash_refresh(slash, printtime);

}

struct winsize ws;

if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&

ws.ws_row != slash->statusline_rows) {

slash_statusline_activate(slash);

return slash_refresh(slash, printtime);

}

char pos[16];

slash_write(slash, "\0337", 2); /* DEC save cursor */

snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);

slash_write(slash, pos, strlen(pos));

slash_statusline_render(slash);

slash_write(slash, "\0338", 2); /* DEC restore cursor */

/* Activation moved cursor; re-run refresh only if it succeeded */

if (slash->statusline_enabled)

return slash_refresh(slash, printtime);

}

if (slash->statusline_enabled) {

struct winsize ws;

if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&

ws.ws_row != slash->statusline_rows) {

slash_statusline_activate(slash);

/* Re-run refresh only if activation updated the tracked row */

if (slash->statusline_enabled &&

ws.ws_row == slash->statusline_rows)

return slash_refresh(slash, printtime);

}

if (slash->statusline_enabled) {

char pos[16];

slash_write(slash, "\0337", 2); /* DEC save cursor */

snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);

slash_write(slash, pos, strlen(pos));

slash_statusline_render(slash);

slash_write(slash, "\0338", 2); /* DEC restore cursor */

}

}

Copilot · 2026-04-07T07:54:19Z

src/slash.c

+			/* Activation moved cursor; re-run refresh at new position */
+			return slash_refresh(slash, printtime);
+		}
+		struct winsize ws;
+		if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&
+		    ws.ws_row != slash->statusline_rows) {
+			slash_statusline_activate(slash);
+			return slash_refresh(slash, printtime);
+		}
+		char pos[16];
+		slash_write(slash, "\0337", 2);  /* DEC save cursor */
+		snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);
+		slash_write(slash, pos, strlen(pos));
+		slash_statusline_render(slash);
+		slash_write(slash, "\0338", 2);  /* DEC restore cursor */


The resize-handling branch also calls slash_statusline_activate() and immediately recurses into slash_refresh(). If activation fails (or terminal reports 0 rows), this can recurse indefinitely. Gate the recursive call on successful activation, or fall back to disabling the statusline for that refresh cycle.

Suggested change

/* Activation moved cursor; re-run refresh at new position */

return slash_refresh(slash, printtime);

}

struct winsize ws;

if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&

ws.ws_row != slash->statusline_rows) {

slash_statusline_activate(slash);

return slash_refresh(slash, printtime);

}

char pos[16];

slash_write(slash, "\0337", 2); /* DEC save cursor */

snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);

slash_write(slash, pos, strlen(pos));

slash_statusline_render(slash);

slash_write(slash, "\0338", 2); /* DEC restore cursor */

if (slash->statusline_enabled && slash->statusline_rows > 0) {

/* Activation moved cursor; re-run refresh at new position */

return slash_refresh(slash, printtime);

}

/* Activation failed or produced no usable row; skip statusline for this cycle */

slash->statusline_enabled = false;

} else {

struct winsize ws;

if (ioctl(slash->fd_write, TIOCGWINSZ, &ws) == 0 &&

ws.ws_row != slash->statusline_rows) {

slash_statusline_activate(slash);

if (slash->statusline_enabled && slash->statusline_rows > 0) {

return slash_refresh(slash, printtime);

}

/* Re-activation failed or terminal reported no usable rows */

slash->statusline_enabled = false;

}

}

if (slash->statusline_enabled && slash->statusline_rows > 0) {

char pos[16];

slash_write(slash, "\0337", 2); /* DEC save cursor */

snprintf(pos, sizeof(pos), "\033[%d;1H", slash->statusline_rows);

slash_write(slash, pos, strlen(pos));

slash_statusline_render(slash);

slash_write(slash, "\0338", 2); /* DEC restore cursor */

}

Copilot · 2026-04-07T07:54:19Z

src/slash.c

+	int rows = ws.ws_row;
+	char esc[32];
+
+	//Set scroll region to all rows except the last.
+	//DECSTBM resets cursor to (1,1) per VT100 spec.
+	snprintf(esc, sizeof(esc), "\033[1;%dr", rows - 1);
+	slash_write(slash, esc, strlen(esc));
+
+	// Move cursor to bottom of scroll region (prompt row)
+	snprintf(esc, sizeof(esc), "\033[%d;1H", rows - 1);
+	slash_write(slash, esc, strlen(esc));


rows - 1 is used to build the scroll region and prompt row escape sequences. If ws.ws_row is 0/1, this generates an invalid/negative row and can corrupt terminal state. Add a guard (e.g., require rows >= 2) and avoid enabling the statusline when the terminal is too small or row count is unavailable.

Copilot · 2026-04-07T07:54:20Z

src/slash.c

+	/* Update statusline on the fixed bottom row */
+#ifdef SLASH_HAVE_TERMIOS_H
+	if (slash_statusline_count() > 0) {
+		if (!slash->statusline_enabled) {


When the last statusline item is removed (count becomes 0), slash_refresh() stops rendering the statusline but never resets the scroll region / clears the reserved bottom row. This can leave the terminal permanently scrolled to rows-1 until exit. Consider deactivating (reset scroll region + clear status row) when slash_statusline_count() == 0 and statusline_enabled is still true.

Copilot · 2026-04-07T07:54:20Z

src/statusline.c

+int _slash_statusline_set_impl(const char * key, const slash_status_opts_t * opts, const char * format, ...) {
+    va_list args;
+
+    // Search for existing key
+    for (int i = 0; i < SLASH_STATUSLINE_MAX_ITEMS; i++) {
+        if (items[i].active && strncmp(items[i].key, key, SLASH_STATUSLINE_KEY_SIZE) == 0) {
+
+            items[i].type = opts->type;
+


opts is dereferenced without a NULL check (opts->type), but _slash_statusline_set_impl is declared in the public header and can be called directly by consumers. Either treat opts == NULL as default options (NORMAL), or hide the impl from the public API so callers must use the macro that always supplies a valid pointer.

Copilot · 2026-04-07T07:54:20Z

src/statusline.c

+static struct slash_statusline_item items[SLASH_STATUSLINE_MAX_ITEMS];
+static int item_count = 0;
+


Statusline state (items / item_count) is stored in global statics, while terminal statusline flags live per struct slash. This means multiple slash instances will share a single global statusline, which is surprising and can cause cross-instance interference. Consider making statusline items part of struct slash (and passing struct slash* to set/remove/count), or explicitly documenting that the statusline API is global/singleton.

Copilot · 2026-04-07T07:54:20Z

include/slash/statusline.h

+ * @param format     Printf-style format string for the display text (rendered max 127 chars).
+ * @param ...        Variadic arguments matching the format string.
+ * @return 0 on success, -1 if no space available.
+ * * @note This is a macro that wraps slash_statusline_set_impl to allow inline struct initialization.


The doxygen comment has a formatting typo (* * @note) and also references slash_statusline_set_impl, but the exposed symbol is _slash_statusline_set_impl. Fixing this will keep generated docs accurate and avoid confusion for API consumers.

Suggested change

* * @note This is a macro that wraps slash_statusline_set_impl to allow inline struct initialization.

* @note This is a macro that wraps _slash_statusline_set_impl to allow inline struct initialization.

Copilot · 2026-04-07T07:54:21Z

src/slash.c

+			if(ret != SLASH_SUCCESS) {
+				slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);


This sets an ERROR statusline for any non-SLASH_SUCCESS return, including SLASH_EXIT (and potentially other non-error control codes). That can incorrectly display "FAILED" for a normal exit. Consider only treating negative return codes as failures, or explicitly excluding SLASH_EXIT (and any other non-error codes) from this branch.

Suggested change

if(ret != SLASH_SUCCESS) {

slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);

if (ret < 0) {

slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR}, "FAILED: %s", line);

Copilot · 2026-04-07T07:54:21Z

src/slash.c

+			#ifdef SLASH_HAVE_TERMIOS_H
+			if(ret != SLASH_SUCCESS) {
+				slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);
+			}
+			#endif


The #ifdef SLASH_HAVE_TERMIOS_H block is indented inside the function body, while the rest of the file consistently places preprocessor directives at column 0 (e.g., src/slash.c:44, :48). Aligning directives to column 0 improves readability and matches the existing style.

Suggested change

#ifdef SLASH_HAVE_TERMIOS_H

if(ret != SLASH_SUCCESS) {

slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);

}

#endif

#ifdef SLASH_HAVE_TERMIOS_H

if(ret != SLASH_SUCCESS) {

slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);

}

#endif

statusline api implemented

e819754

edvardxyz requested review from Copilot, jeanbaptistelab and kivkiv12345 April 7, 2026 07:48

Copilot started reviewing on behalf of edvardxyz April 7, 2026 07:49 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

statusline api implemented#24

statusline api implemented#24
edvardxyz wants to merge 1 commit intomasterfrom
statusline_initial

edvardxyz commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

		static struct slash_statusline_item items[SLASH_STATUSLINE_MAX_ITEMS];
		static int item_count = 0;

	* * @note This is a macro that wraps slash_statusline_set_impl to allow inline struct initialization.
	* @note This is a macro that wraps _slash_statusline_set_impl to allow inline struct initialization.

		if(ret != SLASH_SUCCESS) {
		slash_statusline_set("slash", {.type = SLASH_STATUS_ERROR},"FAILED: %s", line);

Conversation

edvardxyz commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants