Pending spaces list for unconfirmed #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffrr
reviewed
Jun 25, 2025
| @@ -216,8 +216,7 @@ impl TxEvent { | |||
| WHERE id IN ( | |||
| SELECT MAX(id) | |||
| FROM {table} | |||
| WHERE type IN ('bid', 'open') | |||
| AND created_at >= strftime('%s', 'now', '-14 days') | |||
| WHERE space IS NOT NULL | |||
There was a problem hiding this comment.
Could you explain why this change was necessary? this method was supposed to return recent events from last 14 days - the number of events could grow significantly for active wallets and its used in other parts of the code base.
There was a problem hiding this comment.
It is used only for list_spaces, and it returns only one event per space anyway (since GROUP BY).
space IS NOT NULLis to capture all the activity for thependinglist.- No time limit is to make the user be able to see all the spaces he was interested in. This one I can revert is we don't want to show those in
outbidlist.
Also, if this table can grow big it can make sense to add indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new group
pendingfor the spaces which are affected by not yet confirmed transactions.Closes #72
Closes #98