Skip to content

Conversation

@mcara
Copy link
Member

@mcara mcara commented Oct 28, 2025

In preparation for release 3.0 of drizzle package, this PR disables treatment of deprecation warnings to be introduced in the upcoming release of the drizzle as errors during testing.

This PR can be reverted after drizzle v3.0.0 is released and #2009 is merged.

CC: @pllim

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.skycell.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@mcara mcara added this to the 26Q1_B20 milestone Oct 28, 2025
@mcara mcara requested a review from schlafly October 28, 2025 06:23
@mcara mcara self-assigned this Oct 28, 2025
@mcara mcara requested a review from a team as a code owner October 28, 2025 06:23
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.48%. Comparing base (6fe41fe) to head (d39399f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         138      138           
  Lines        8278     8278           
=======================================
  Hits         6497     6497           
  Misses       1781     1781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

]
filterwarnings = [
"error::ResourceWarning",
"error::DeprecationWarning",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the ignore would override the "error" here. I think the order matters but I don't remember now which way.

@schlafly
Copy link
Collaborator

My understanding of the issue here is that if we had pinned drizzle < 3 here:
https://github.com/spacetelescope/romancal/blob/main/pyproject.toml#L36C5-L36C24
our existing release would be fine. Since we did not do that, I think you're suggesting we put this patch in to our next release, and then the drizzle stuff can proceed? If we are going to do a romancal patch release, we could alternatively pin to versions < 3 instead?

@mcara
Copy link
Member Author

mcara commented Oct 28, 2025

You could pin it to <3.0 but then DQ flag propagation will not be available. The main issue is about testing and this PR affects testing only - not running the pipeline.

Here is my reply to a longer discussion in jwst on a similar PR: spacetelescope/jwst#9963 (comment)

@mcara
Copy link
Member Author

mcara commented Oct 28, 2025

Also without this PR, in #2009 all unit tests fail.

@mcara
Copy link
Member Author

mcara commented Oct 28, 2025

Basically this PR addresses spacetelescope/drizzle#203 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants