-
Notifications
You must be signed in to change notification settings - Fork 34
Temporarily don't treat drizzle deprecation warnings as errors #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Temporarily don't treat drizzle deprecation warnings as errors #2020
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 138 138
Lines 8278 8278
=======================================
Hits 6497 6497
Misses 1781 1781 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! xref
| ] | ||
| filterwarnings = [ | ||
| "error::ResourceWarning", | ||
| "error::DeprecationWarning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the ignore would override the "error" here. I think the order matters but I don't remember now which way.
|
My understanding of the issue here is that if we had pinned drizzle < 3 here: |
|
You could pin it to <3.0 but then DQ flag propagation will not be available. The main issue is about testing and this PR affects testing only - not running the pipeline. Here is my reply to a longer discussion in |
|
Also without this PR, in #2009 all unit tests fail. |
|
Basically this PR addresses spacetelescope/drizzle#203 (comment) |
In preparation for release 3.0 of
drizzlepackage, this PR disables treatment of deprecation warnings to be introduced in the upcoming release of thedrizzleas errors during testing.This PR can be reverted after
drizzle v3.0.0is released and #2009 is merged.CC: @pllim
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.associations.rstchanges/<PR#>.scripts.rstchanges/<PR#>.mosaic_pipeline.rstchanges/<PR#>.skycell.rststeps
changes/<PR#>.dq_init.rstchanges/<PR#>.saturation.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.jump_detection.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.assign_wcs.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.photom.rstchanges/<PR#>.flux.rstchanges/<PR#>.source_detection.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.resample.rstchanges/<PR#>.source_catalog.rst