Merged
Conversation
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
9b7fcc9 to
bd8db28
Compare
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
There was a problem hiding this comment.
Pull Request Overview
This PR applies various fixes to ensure the documentation is in sync with the main Spack repository and resolves formatting, style, and configuration issues.
- Fixes Google Analytics token to use tutorial-specific tracking instead of conflating with spack.readthedocs.io
- Updates conf.py configuration to match spack/spack and adds custom HTML formatter
- Applies consistent RST formatting throughout documentation files
Reviewed Changes
Copilot reviewed 19 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| _templates/base.html | Updates Google Analytics tracking ID from shared to tutorial-specific |
| conf.py | Synchronizes configuration with spack/spack, adds custom HTML formatter, and updates extensions |
| .readthedocs.yaml | Enables fail_on_warning and adds post_checkout job for accurate timestamps |
| .gitmodules | Adds _spack_packages submodule reference |
| _spack_packages | Adds submodule commit reference |
| .github/workflows/style.yml | Updates style check workflow to install dependencies and use proper file selection |
| tutorial_*.rst files | Applies consistent RST formatting by breaking long lines and fixing indentation |
| common/setup.rst | Applies line formatting fixes |
| index.rst | Applies line formatting fixes |
Comments suppressed due to low confidence (1)
conf.py:1
- The path appears to have an extra '/base' directory. Should be
_spack_root/etc/spack/defaults/packages.yamlbased on standard Spack directory structure.
# Copyright Spack Project Developers. See COPYRIGHT file for details.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alalazo
previously approved these changes
Sep 2, 2025
ca70e19 to
c627c76
Compare
c627c76 to
c15e79c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.