Skip to content

Fix JSON deserialization error for abstract DrapoComponentFile in bot requests #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix JSON deserialization error for abstract DrapoComponentFile in bot requests #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4bc55
Initial plan
Copilot Jan 5, 2026
ab84cd0
Fix bot config error by avoiding DrapoComponentFile deserialization
Copilot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions src/Middleware/Drapo/DrapoMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
Expand Down Expand Up @@ -352,17 +353,27 @@ private async Task<string> GetConfigContentForRequestAsync(HttpContext context)
if (dynamicRoutes == null || dynamicRoutes.Count == 0)
return baseContent;

// Deserialize the base config, add dynamic routes, and serialize back
DrapoConfig config = JsonConvert.DeserializeObject<DrapoConfig>(baseContent);
// Parse JSON and add dynamic routes without full deserialization to avoid
// instantiation issues with abstract DrapoComponentFile class
JObject configJson = JObject.Parse(baseContent);

// Combine static routes with dynamic routes (dynamic routes take precedence)
// Pre-size the list for better performance
List<DrapoRoute> combinedRoutes = new List<DrapoRoute>(dynamicRoutes.Count + config.Routes.Count);
combinedRoutes.AddRange(dynamicRoutes);
combinedRoutes.AddRange(config.Routes);
config.Routes = combinedRoutes;
// Get existing routes array or create new one
JArray routesArray = configJson["Routes"] as JArray ?? new JArray();

return JsonConvert.SerializeObject(config);
// Add dynamic routes at the beginning (they take precedence)
JArray newRoutesArray = new JArray();
foreach (DrapoRoute route in dynamicRoutes)
{
newRoutesArray.Add(JObject.FromObject(route));
}
foreach (JToken existingRoute in routesArray)
{
newRoutesArray.Add(existingRoute);
}

configJson["Routes"] = newRoutesArray;

return configJson.ToString(Formatting.None);
}

private bool IsBotRequest(HttpContext context)
Expand All @@ -386,9 +397,11 @@ private bool IsBotRequest(HttpContext context)
private string GetConfigContentForBot()
{
string configContent = GetConfigContent();
DrapoConfig configBot = JsonConvert.DeserializeObject<DrapoConfig>(configContent);
configBot.CanUseWebSocket = false;
return (JsonConvert.SerializeObject(configBot));
// Parse JSON and modify CanUseWebSocket property without deserializing to avoid
// instantiation issues with abstract DrapoComponentFile class
JObject configJson = JObject.Parse(configContent);
configJson["CanUseWebSocket"] = false;
return configJson.ToString(Formatting.None);
}

private bool HasDynamicRoutes()
Expand Down