Draft
Conversation
peter-svensson
force-pushed
the
rework
branch
2 times, most recently
from
a1cf8db to
9f2d061
Compare
argoyle
previously approved these changes
Feb 9, 2024
Member
argoyle
left a comment
argoyle
left a comment
There was a problem hiding this comment.
Loads of changes. Looks good to me. Just one small comment. 🏎️
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 91.86% 93.77% +1.90%
==========================================
Files 9 15 +6
Lines 578 610 +32
==========================================
+ Hits 531 572 +41
- Misses 32 33 +1
+ Partials 15 5 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peter-svensson
force-pushed
the
rework
branch
14 times, most recently
from
8c1a1fc to
a33ae3f
Compare
peter-svensson
force-pushed
the
rework
branch
from
f8fdf70 to
2a5599b
Compare
peter-svensson
force-pushed
the
rework
branch
3 times, most recently
from
7b13d1f to
fbb3d76
Compare
# Conflicts: # connection.go
Update the queue declaration in tests to include the `exclusive` parameter and align the expected arguments with the current configuration using `defaultQueueOptions`. Change the queue type from "classic" to "quorum" for improved message handling. Refactor the `ServiceRequestConsumer` function to accept additional options for flexibility in queue setup. Remove redundant test code to streamline maintenance.
Update the messaging configuration structure from QueueBindingConfig to ConsumerConfig to improve clarity and better represent the usage of the configuration in the context of consumer setup. This change includes updates to related methods and tests to ensure consistent naming and functionality throughout the codebase.
Change queue type assignments from string literals to constants from the AMQP library for improved consistency and clarity. Update related test cases to reflect the new constant usage. Introduce QoS configuration to enhance consumer performance and round-robin behavior.
This commit updates the Go version specified in the go.mod file from 1.22.12 to 1.23. This change ensures compatibility with the latest features and improvements in the Go 1.23 release.
Implements a Close method for the MockAmqpChannel struct to satisfy the io.Closer interface. This allows for better integration with code that requires closing channels gracefully in tests. Additionally, it updates the AmqpChannel interface to include the io.Closer interface.
Update the Time-To-Live (TTL) for message queues from 1 to 1000 across various test cases and the consumer setup. This change ensures that messages have a longer lifespan, allowing for better testing conditions and more reliability in message delivery during integration scenarios. Adjustments are made in the consumer setup and corresponding test files to align with this new TTL requirement.
Refactor the ConsumerConfig to consumerConfig for consistency across the codebase. Update tests and functions to utilize the new struct definition while ensuring the functionality remains intact. This change improves code clarity and aligns with naming conventions,
Adds the typemapper library for enhanced message type mapping in AMQP. Modifies the Publisher and consumer setups to utilize the new mapper, allowing improved error handling and consistency in route mapping between types and routing keys. Updates tests to reflect changes in message handling and type validation. This refactor aims to simplify type management and reduce potential errors in message routing.
Refactor the Publisher setup method to remove unnecessary parameters. Adjust the integration test to handle the new publish call. Update go.mod to specify the Go toolchain version. Refine test cases for clearer header handling and update expected behavior in tests to align with latest changes.
This update changes the copyright year from 2024 to 2025 in all relevant files to ensure accurate copyright information for the current year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.