fix: address code review findings

__tests__/consumer.test.ts

@@ -380,11 +380,11 @@ describe("QueueConsumer", () => {
     expect(channel.nack).not.toHaveBeenCalled();
   });
 
-  it("logs consumer loop exit on stop()", () => {
+  it("logs consumer stop at info level", () => {
     consumer.stop();
 
-    expect(silentLogger.warn).toHaveBeenCalledWith(
-      expect.stringContaining("consumer loop exited, delivery channel closed"),
+    expect(silentLogger.info).toHaveBeenCalledWith(
+      expect.stringContaining("consumer stopped"),
     );
     expect(consumer.isStopped()).toBe(true);
   });
@@ -393,16 +393,16 @@ describe("QueueConsumer", () => {
     consumer.stop();
     consumer.stop();
 
-    const stopCalls = silentLogger.warn.mock.calls.filter(
-      (call: unknown[]) => typeof call[0] === "string" && (call[0] as string).includes("consumer loop exited"),
+    const stopCalls = silentLogger.info.mock.calls.filter(
+      (call: unknown[]) => typeof call[0] === "string" && (call[0] as string).includes("consumer stopped"),
     );
     expect(stopCalls).toHaveLength(1);
   });
 
   describe("legacySupport", () => {
     it("enriches metadata for messages without CE headers when legacySupport is enabled", async () => {
       const legacyConsumer = new QueueConsumer(
-        "test-queue", silentLogger, undefined, undefined, undefined, undefined, undefined, true,
+        "test-queue", silentLogger, undefined, { legacySupport: true },
       );
       const handler = mock(() => Promise.resolve(undefined));
       legacyConsumer.addHandler("order.created", handler);
@@ -428,7 +428,7 @@ describe("QueueConsumer", () => {
 
     it("does not enrich metadata for messages WITH CE headers when legacySupport is enabled", async () => {
       const legacyConsumer = new QueueConsumer(
-        "test-queue", silentLogger, undefined, undefined, undefined, undefined, undefined, true,
+        "test-queue", silentLogger, undefined, { legacySupport: true },
       );
       const handler = mock(() => Promise.resolve(undefined));
       legacyConsumer.addHandler("order.created", handler);
@@ -464,7 +464,7 @@ describe("QueueConsumer", () => {
 
     it("logs debug messages for legacy message detection and enrichment", async () => {
       const legacyConsumer = new QueueConsumer(
-        "test-queue", silentLogger, undefined, undefined, undefined, undefined, undefined, true,
+        "test-queue", silentLogger, undefined, { legacySupport: true },
       );
       const handler = mock(() => Promise.resolve(undefined));
       legacyConsumer.addHandler("order.created", handler);

__tests__/metrics.test.ts

@@ -165,7 +165,7 @@ describe("AMQP Consumer Metrics", () => {
 
   it("calls eventReceived and eventAck on successful handler", async () => {
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics,
+      "test-queue", silentLogger, undefined, { metrics },
     );
     consumer.addHandler("order.created", mock(() => Promise.resolve(undefined)));
     await consumer.consume(channel as unknown as import("amqplib").Channel);
@@ -184,7 +184,7 @@ describe("AMQP Consumer Metrics", () => {
 
   it("calls eventNack on handler error", async () => {
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics,
+      "test-queue", silentLogger, undefined, { metrics },
     );
     consumer.addHandler("order.created", mock(() => Promise.reject(new Error("fail"))));
     await consumer.consume(channel as unknown as import("amqplib").Channel);
@@ -203,7 +203,7 @@ describe("AMQP Consumer Metrics", () => {
 
   it("calls eventWithoutHandler when no handler matches", async () => {
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics,
+      "test-queue", silentLogger, undefined, { metrics },
     );
     consumer.addHandler("order.created", mock());
     await consumer.consume(channel as unknown as import("amqplib").Channel);
@@ -220,7 +220,7 @@ describe("AMQP Consumer Metrics", () => {
 
   it("calls eventNotParsable on invalid JSON", async () => {
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics,
+      "test-queue", silentLogger, undefined, { metrics },
     );
     consumer.addHandler("order.created", mock());
     await consumer.consume(channel as unknown as import("amqplib").Channel);
@@ -238,7 +238,7 @@ describe("AMQP Consumer Metrics", () => {
   it("applies routingKeyMapper before passing to metrics", async () => {
     const mapper = (key: string) => key.replace(/\.\d+/, ".ID");
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics, mapper,
+      "test-queue", silentLogger, undefined, { metrics, routingKeyMapper: mapper },
     );
     consumer.addHandler("order.#", mock(() => Promise.resolve(undefined)));
     await consumer.consume(channel as unknown as import("amqplib").Channel);
@@ -255,10 +255,10 @@ describe("AMQP Consumer Metrics", () => {
     );
   });
 
-  it("replaces empty mapped routing key with 'unknown'", async () => {
+  it("replaces empty mapped routing key with unknown", async () => {
     const mapper = () => "";
     const consumer = new QueueConsumer(
-      "test-queue", silentLogger, undefined, undefined, undefined, metrics, mapper,
+      "test-queue", silentLogger, undefined, { metrics, routingKeyMapper: mapper },
     );
     consumer.addHandler("order.created", mock(() => Promise.resolve(undefined)));
     await consumer.consume(channel as unknown as import("amqplib").Channel);

__tests__/notifications.test.ts

@@ -123,7 +123,7 @@ describe("AMQP notifications", () => {
       "test-queue",
       silentLogger,
       undefined,
-      onNotification,
+      { onNotification },
     );
 
     const handler = mock(() => Promise.resolve(undefined));
@@ -153,8 +153,7 @@ describe("AMQP notifications", () => {
       "test-queue",
       silentLogger,
       undefined,
-      undefined,
-      onError,
+      { onError },
     );
 
     const handlerError = new Error("handler failed");

__tests__/prefetch-and-channel-close.test.ts

@@ -330,7 +330,7 @@ describe("channel close listener", () => {
     consumerCh.emit("error", new Error("channel reset"));
 
     expect(silentLogger.warn).toHaveBeenCalledWith(
-      expect.stringContaining("consumer loop exited, delivery channel closed"),
+      expect.stringContaining("channel error: channel reset"),
     );
   });
 });