Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- H1: Only suppress NATS error codes 10058/10059 in stream catch blocks, rethrow all other errors instead of silently swallowing them - H2: Rethrow errors for ephemeral consumer creation instead of silently ignoring failures - H3: Replace long positional parameter lists in startJSConsumers and startCoreConsumers with JSConsumerOptions/CoreConsumerOptions interfaces - M2: Replace non-null assertion on msg.headers with guard pattern - M3: Use module-level TextEncoder/TextDecoder instances instead of allocating per message - M4: Validate that backOff array length does not exceed maxDeliver
peter-svensson
force-pushed
the
fix/code-review-findings
branch
from
5d9ea73 to
fc1132d
Compare
… ephemeral consumer errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startJSConsumersandstartCoreConsumerswithJSConsumerOptionsandCoreConsumerOptionsoption interfaces.msg.headers!) with a guard check before callingextractToContext.TextEncoderandTextDecoderto module-level singletons instead of allocating per message.backOffarray length does not exceedmaxDeliver, throwing early with a clear message.Test plan
bun run typecheckpassesbun test)