Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Add exponential backoff with jitter on broker publish failures (H1) - Track stopPromise for start/stop re-entrancy safety (H2) - Swap CE header spread order so required fields cannot be overridden (H3) - Validate RelayConfig batchSize and pollIntervalMs are positive (M1) - Inline migration SQL to remove runtime filesystem dependency (M2) - Remove string-only Logger overloads, keep object form only (M3) - Add comment explaining batchWasFull conservative heuristic (M4) - Add JSDoc to OutboxInserter explaining why Writer supplies id/created_at (L1) - Replace setTimeout-based test timing with promise synchronization (L2)
peter-svensson
force-pushed
the
fix/code-review-findings
branch
from
0f84356 to
9eb10ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm testpassesnpm run lintpasses