API-9331 fix regressions on 'Not' operations#80
Merged
Conversation
|
|
||
| assert sample("Test Eq true Not (Test Eq 'Drop' And Test Eq false)") | ||
| assert !sample("Test Eq true Not (Test Eq 'Drop' And Test Eq true)") | ||
| assert !sample("Test Eq true Not (Test Eq 'Drop' And Test Eq true)") |
codygustafson
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a regression in the evaluator rewrite introduced in this PR.
In some instances, the new implementation would include additional expressions to the
Notwhen it wasn't supposed to. I've expanded on the test scenarios accordingly, and spend some time on including every permutation for scenarios.