Closed
Conversation
…YSTEM_actionItem naming convention loosely in place in the VCU
…ng. Enabling a positive feedback loop between pl and the mcm output so long as it is less than the driver requested torque
…ng. Enabling a positive feedback loop between pl and the mcm output so long as it is less than the driver requested torque
…ngelectric/VCU into harleenDevLC+PLvers2
…ing them for PNR this weekend
…t in my branch may have been more appropiate but alas I will make do with the powers of Ctrl+C & Ctrl+V
… may seem like I enjoy doing this, I don't. A naming convention should be established and applied to all variable & function names. While not a big deal in the context of making a car run, it is also simultaneously extremely important, as poor/inconsistant naming conventions is still one of the biggest barriers to understanding what is happening in our code at any given point, especially from the perspective of a first time viewer. This problem is exacerbated when important information such as 'from what struct are we getting a value?' is left out of the name. Such issues needlessly worsen the learning curve, and is a barrier that can be easily removed by taking a few extra seconds and being proper in all areas of coding, not just ones we deem worthy based upon a whim. These decisions should not be made unilaterally by me. A unified decision should be made by all involved parties. -rant done
… in powerLimit.c & motorController.c
…revious commit, as well as adding in bpsTorque to torqueOutput in what I hope is the correct manner of things
Most of the calculations should be in nM for simplicity sake, the nM--> decinM conversion should be done as the last step, to ensure readability/
…ake a saturation value instead of setpoint on initialization bc the setpoint is updated every cycle anyways, and removing the separate pl pid struct
… forced TQ equation override. LUT still gives bad values. Bug fix to anti-windup measures. and the dbc has been updated to expect N-m outputs from the pid and deciN-m commandedTorque
…ommenting or defining of code. also, changing a function name to give better clarity to the caller of the function. Finally, plpPID added back in, with a hopefully redundant clamp on the Torque request.
…tial for a multiply by 0 call which would massively derail the incomplete factorization of the double linear interpolation equation.
…orward + informations contained within should be discussed and structured as to avoid abuse and bloat of this file. Additionally, corrected and made neccessary changes within files that are using these global constants
…tric/VCU into SR-16_Controls
… previous PLActive on next occurence of activating PL. Also, fixing error in saturation adds.
Author
|
used for merge main -> controls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.