Skip to content

Issue 2#4

Merged
ionides merged 2 commits intospatPomp-org:masterfrom
juliansgottfried:issue_2
Aug 19, 2025
Merged

Issue 2#4
ionides merged 2 commits intospatPomp-org:masterfrom
juliansgottfried:issue_2

Conversation

@juliansgottfried
Copy link
Copy Markdown
Contributor

Issue
#2

File changes
In spatPomp.R:

Changed line 222 to
pomp_data <- pomp_data |> dplyr::mutate(obsname = paste0(.data$obsname,.data$ui)) |> dplyr::select(-all_of(unitname)) |> dplyr::select(-.data$ui)

Changed line 260 to
pomp_covar <- pomp_covar |> dplyr::mutate(covname = paste0(.data$covname,.data$ui)) |> dplyr::select(-all_of(unitname)) |> dplyr::select(-.data$ui)

Unit tests

  • I have run the existing unit tests
  • I have added unit tests for my changes

@ionides ionides merged commit f533be7 into spatPomp-org:master Aug 19, 2025
6 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants