Allow assertMatchesJsonSnapshot
to accept any JSON-serializable value
#216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the strict type annotation from the
$actual
parameter inassertMatchesJsonSnapshot()
to allow any JSON-serializable value, includingJsonSerializable
objects.The underlying
JsonDriver
already accepts mixed input, so this change relaxes the input constraint to better reflect its capabilities. It also improves consistency with otherassertMatches*Snapshot
methods, which do not restrict input types.