Fix issue 15: synchronize data races in rdfloader#16
Open
bbadour wants to merge 2 commits intospdx:masterfrom
Open
Fix issue 15: synchronize data races in rdfloader#16bbadour wants to merge 2 commits intospdx:masterfrom
bbadour wants to merge 2 commits intospdx:masterfrom
Conversation
Sort the unique triples in GetNodeToTriples to make the order determinate. Add logging to topological sort test to aid debugging.
Use `sync/atomic` to synchronize the `Node.lastid` accesses, and the existing `Parser.writeLock` to synchronize accesses to the deferenced error pointer. Introduce a package-private `Node.set` method to support initializing `lastid` to different values.
Author
|
Didn't mean to make the fix for 14 a child of the fix for 12/13, but my git-foo is inadequate to figure out how to rebase the pull request here. 🤷 |
bbadour
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
sync/atomicto synchronize theNode.lastidaccesses, and theexisting
Parser.writeLockto synchronize accesses to the deferencederror pointer.
Introduce a package-private
Node.setmethod to support initializinglastidto different values.