Draft
Conversation
Collaborator
Author
|
Adding "pattern" to |
Collaborator
Author
|
With I get only one parameter: This surprises me a bit, I thought ";" as a terminating would make me have 3 parameters. We can get 3 parameters using the notation of the paper |
Contributor
|
I think the reason is that the basic spec parser uses other terminating keywords than the structured spec and library parsers. |
…ations in pattern bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not intended for merging, ignore any style issue or use of tracing messages.
Issues:
gives a parse error because the list is not the last element in the list of parameters. Moving the optional argument before it makes the example go through. The fact that the parameter following the list is optional has no relevance (removing the ? still gives an error).
I would have the same problem in instantiations
P[A; X::Xs; B]so I have not implemented this yet.goes through, but removing the optional end after the local patterns makes the parser fail (
skipas a separator most likely not the best idea). At the level oflibItems, that also have an optional end, these are parsed with a recursive function that also tries to parse annotation. Should follow the same approach here?How should I parse the missing optional parameter?
Using
hetIRIto parsegreater[C]does not work. I have usedcompoundIriCurie. But I wonder ifhetIRIdoes what it should.