PEM-8858: Update forklift version to 2.9 vesion #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ev2v#1960) Motivation Using the PVs volumeHandle may not be enough for some ontap installation. The name of the LUN in ontap is set by the CSI driver, and the default prefix, "trident_pvc_" that is controlled by the trident configuration can be different. That breaks the resolve logic. Modification When using ontap, trident CSI is setting the real name of the lun using the volume attribute 'internalName'. Using that looks is more reliable than the heuristic with the volumeHandle Result ontap provider will work with whatever trident configuration `TridentBackend.config.ontap_config.storage_prefix` is set to. https://issues.redhat.com/browse/ECOPROJECT-2880 Signed-off-by: Roy Golan <rgolan@redhat.com> Signed-off-by: Roy Golan <rgolan@redhat.com>
Signed-off-by: Martin Necas <mnecas@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=fef113294f3adc2a041c78b5bfc856798c87c16d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…6-1747218906 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
… tag to v1.23.6-1747333074 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
… tag to v1.23.6-2.1747189110 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=4afe71467378c9280e32d58bab009b1b787d3f73' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Issue: The forklift-volume-populator-controller is created with empty VSPHERE_XCOPY_VOLUME_POPULATOR_IMAGE. Fix: Add missing VSPHERE_XCOPY_VOLUME_POPULATOR_IMAGE to manager and run `make generate-manifests` Signed-off-by: Martin Necas <mnecas@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=7ffd7a2b052ef586b28e96c6dd9be6cfb4950b96' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…el9 docker digest to 2a659b5 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#1923) Rather than returning information from the collector database, use the kubernetes client within the inventory controller to fetch information for OCP 'host' providers. See commit "inventory: Introduce concept of namespace-restricted host providers" for a detailed explanation of changes in behavior for some 'host' providers. --------- Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=3a4bc1dac4c35e16465a35b9adfdb8b00594108c' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: Roy Golan <rgolan@redhat.com>
The build target contains the needed build tags to make sure the VIB version is injected into the binary Signed-off-by: Roy Golan <rgolan@redhat.com>
Issue: Failed to migrate VM from vsphere provider skipped VDDK acceleration Fix: Block the warm plans migration without the VDDK as it's mandatory. Ref: https://issues.redhat.com/browse/MTV-2687 Signed-off-by: Martin Necas <mnecas@redhat.com>
Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=48eb8800feb6b4fa6f3369dcd75b087737129001' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: yaacov <kobi.zamir@gmail.com>
… a non-ready state Issue: Creating a VMware provider with wrong ip for example https://10.10.10.10/sdk ending with creating the provider with "undefined" state and the forkflift-controller gets stuck. Fix: 1. Add a timeout to the tls-certificate method. 2. Change provider condition upon timeout 3. Update provider status after validation failure Ref: https://issues.redhat.com/browse/MTV-2669 Signed-off-by: Elad <ehazan@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=6a3ae9a9749acaeeb15794ca4e13fa9acce50de6' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: yaacov <kobi.zamir@gmail.com>
Signed-off-by: Martin Necas <mnecas@redhat.com>
Signed-off-by: Martin Necas <mnecas@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=5af5fb43da71d874d884089728aae365507057b1' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=5af5fb43da71d874d884089728aae365507057b1' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
![bulwark-spectrocloud[bot]](https://avatars.githubusercontent.com/u/36211249?s=60&v=4){kind=small}
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2360:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1780:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
PEM-9332: VMM: Migration failing in pod security
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
- GO-2025-4155
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/inventory/web/client.go:286:20: web.Watch calls web.Watch$1, which eventually calls tls.VerifyHostname
2. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
- GO-2025-4175
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
adding support to build virt-v2v-frdora
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
- GO-2025-4155
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
2. pkg/lib/inventory/web/client.go:286:20: web.Watch calls web.Watch$1, which eventually calls tls.VerifyHostname
- GO-2025-4175
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
- GO-2025-4155
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/inventory/web/client.go:286:20: web.Watch calls web.Watch$1, which eventually calls tls.VerifyHostname
2. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
- GO-2025-4175
- Module: stdlib
- Found in: v1.24.10
- Fixed in: v1.24.11
- Example Traces:
1. pkg/lib/util/util.go:72:33: util.GetTlsCertificate calls util.dialTLSWithTimeout, which eventually calls tls.processCertsFromClient
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
PEM-9350: Windows 25 server VM shows "inaccessible boot device" error after migration
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
PEM-8574: adding secure boot missing smm fix
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
PEM-9715 Epic Add the full property file
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
Remove NVMe disk validation policies that were blocking migration of VMs with NVMe disks, and add NVMe to the supported disk bus types in the builder. Changes: - Delete nvme_disk.rego and nvme_disk test.rego validation policies - Add container.NVME to sortedDisksAsLibvirt() and sortedDisksAsVmware() bus lists to properly include NVMe disks during migration Source NVMe disks are converted to VirtIO (default) or SATA (compatibility mode) on the target. Based on upstream: MTV-2444
PEM-9675: Pull upstream changes to spectrocloud/forklift and validate the changes
There was a problem hiding this comment.
- GO-2024-2955
- Module: github.com/gin-contrib/cors
- Found in: v1.3.1
- Fixed in: v1.6.0
- Example Traces:
1. pkg/lib/inventory/web/web.go:45:21: web.Start calls cors.New, which eventually calls web.Start
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion uint64 -> int64, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/filebacked/file.go:330:12
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:531:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:128:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:126:13
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:2359:15
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:880:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/vsphere/builder.go:879:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:354:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ova/builder.go:353:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:378:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:377:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/builder.go:376:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:115:23
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encoder.go:77:34
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/gob/encode.go:371:25
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/vm_name_handler.go:112:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/kubevirt.go:1779:10
-
- G402: TLS MinVersion too low., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/tests/suit/utils/http.go:27:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:82:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:192:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go:95:62
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:199-201:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:307-309:32
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:75:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ocp/builder.go:570-572:17
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/base/controller.go:146-148:16
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/client/openstack/client.go:180:48
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib-volume-populator/populator-machinery/controller.go:1071:52
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/validation/policy/client.go:204:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/web/base/client.go:313:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/ovirt/client.go:66:53
-
- File: /home/runner/work/bulwark/bulwark/target-repo/cmd/vsphere-xcopy-volume-populator/internal/vantara/vantara-api.go:122:53
- ... (truncated), run gosec locally to capture all failure for the rule G402
-
- G401: Use of weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:99:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:667:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:12:10
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:1231:9
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:264:14
-
- G505: Blocklisted import crypto/sha1: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/util/util.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/table.go:5:2
-
- G501: Blocklisted import crypto/md5: weak cryptographic primitive, Severity: MEDIUM
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/provider/container/vsphere/utils.go:4:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/validation.go:5:2
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/controller/plan/adapter/ovirt/client.go:4:2
-
- G602: slice index out of range, Severity: LOW
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:223:7
-
- File: /home/runner/work/bulwark/bulwark/target-repo/pkg/lib/inventory/model/field.go:221:7
-
Please review these findings and fix the issues before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.